feat(ui): simplify session detail sidebar layout#19
Conversation
- Remove redundant status badge ('Working', 'Idle') - dot color already conveys status
- Remove agent label text ('Codex CLI') - icon already shows agent type
- Remove 'LOCATION' section header - unnecessary visual weight
- Remove folder icon + project name line - path is sufficient
- Keep branch name + path with copy-to-clipboard
Result: More compact sidebar with essential info immediately visible.
Closes: td-26d768
Summary of ChangesHello @Helmi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the session detail sidebar layout by eliminating superfluous UI components and consolidating information. The changes aim to create a more compact and visually efficient display, ensuring that essential session details are immediately visible without unnecessary clutter. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully simplifies the session detail sidebar layout by removing redundant UI elements as described. The changes effectively reduce visual clutter, making essential information more immediately visible. All modifications, including the removal of statusLabels, Folder icon, currentProject usage, and the agentLabel variable, are consistent with the stated goals of the pull request. The minor adjustments to spacing (space-y-2 to space-y-3 and space-y-1.5) are appropriate for the refined layout. No functional issues, performance bottlenecks, or security vulnerabilities were introduced.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f09b64ea24
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {/* Session Info - Header area with status dot, icon, and name */} | ||
| <div className="space-y-3"> | ||
| <div className="flex items-center gap-2 min-w-0"> | ||
| <StatusIndicator status={mapSessionState(session.state)} size="md" /> |
There was a problem hiding this comment.
The new header now exposes session state only through the colored StatusIndicator dot, which removes the non-color cue that was previously present via the status badge text. In scenarios with color-vision deficiency, low-contrast themes, or screen-reader navigation, users can no longer reliably distinguish idle vs working vs waiting_input from this view, so this is a usability/accessibility regression introduced by the layout simplification.
Useful? React with 👍 / 👎.
Code ReviewClean, focused PR. The diff achieves its goal well. The sidebar is more compact and the important info (status dot, icon, branch, path) is still immediately visible. Positives
Issues / Things to considerAccessibility concern (medium) Status is now communicated only via dot color. Screen readers and color-blind users have no text equivalent. The StatusIndicator component likely does not carry an aria-label. Consider adding an aria-label or title prop to the status dot that surfaces the text status string (e.g. 'Status: Working'). Leftover blank line (nit) After removing agentLabel there is a trailing blank line around line 51 in the resulting file. Minor but visible in diffs. Lost project context currentProject is removed and the project name row is gone. For single-project setups this is fine, but once multi-project support lands (GlobalSessionOrchestrator is already in the codebase), two sessions from different projects will look identical in the sidebar. Worth a follow-up issue, or at least keeping the data wired up so it is easy to re-surface later. Agent identification fallback (minor) If agentIcon is undefined (no config match, no legacy match), AgentIcon renders a generic fallback. Without the label there is no text hint for which agent type this is. Low priority unless agent icons are not always distinctive enough. SummaryApproval-worthy change. The accessibility item is worth a follow-up issue if not addressed here, and the multi-project concern is a heads-up for future work rather than a blocker. Everything else is clean. |
1 participant
Summary
Result
More compact sidebar with essential info immediately visible.
Before: Status dot + icon + name → badge + agent label → 'LOCATION' header → folder + branch + path
After: Status dot + icon + name → branch + path
Closes: td-26d768